Opened 13 years ago

Closed 13 years ago

#20 closed defect (fixed)

Incorrect parsing of flag_values attribute

Reported by: ros Owned by: ros
Priority: medium Milestone:
Component: cf-checker Version:
Keywords: Cc:

Description

Section 3.5 of the conventions document states that "The flag_values attribute is the same type as the variable to which it is attached, and contains a list of the possible flag values."

E.g. 

current_speed_qc:flag_values = 0b, 1b, 2b ;

But Appendix A specified the flag_values type as string. This is what the checker based the check on which is incorrect.

The conventions document has been corrected. The CF checker needs to implement this change too.

Change History (2)

comment:1 Changed 13 years ago by ros

  • Owner changed from cf-checker@… to ros
  • Status changed from new to assigned

Fixed in revision [53]

Type of the attribute flag_values changed to (D). Extra check added to the routine chkAttribute()

Note: A list of chars is equivalent to a string which is a 1D character array. (i.e. "a","b" is the same as "ab")

Test Files:
source:/cf-checker/trunk/test_files/Trac020_test1.nc#54
source:/cf-checker/trunk/test_files/Trac020_test2.nc#54

comment:2 Changed 13 years ago by ros

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.